DXGL r454 - Code Review

Jump to navigation Jump to search
Repository:DXGL
Revision:< r453‎ | r454 | r455 >
Date:22:05, 1 July 2014
Author:admin
Status:new
Tags:
Comment:
Fix missing ret instruction in _itoa_x86.asm and memcpy_x86.asm of minilibc, thanks Alcaro of smwcentral.net for pointing it out.
Modified paths:
  • /minilibc/_itoa_x86.asm (modified) (history)
  • /minilibc/memcpy_x86.asm (modified) (history)

Diff [purge]

Index: minilibc/_itoa_x86.asm
——@@ -81,6 +81,7 @@
8282 pop edx
8383 pop edi
8484 pop esi
 85+ ret
8586 _itoa ENDP
8687
8788 end
\ No newline at end of file
Index: minilibc/memcpy_x86.asm
——@@ -38,6 +38,7 @@
3939 pop ecx
4040 pop edi
4141 pop esi
 42+ ret
4243 memcpy_386 ENDP
4344
4445 end
Retrieved from "https://dxgl.org/wiki/Special:Code/DXGL/454"