DXGL r18 - Code Review

Jump to navigation Jump to search
Repository:DXGL
Revision:r17‎ | r18 | r19 >
Date:19:08, 4 December 2011
Author:admin
Status:new
Tags:
Comment:
Add DXGL icon to installer.
Modify icons to take less space.
Begin adding profile removal to dxglcfg
Modified paths:
  • /Installer/dxgl.nsi (modified) (history)
  • /common/dxgl.ico (modified) (history)
  • /common/dxgl48.ico (added) (history)
  • /common/star.ico (modified) (history)
  • /dxglcfg/dxglcfg.cpp (modified) (history)

Diff [purge]

Index: Installer/dxgl.nsi
@@ -19,7 +19,7 @@
2020
2121 ; MUI Settings
2222 !define MUI_ABORTWARNING
23 -!define MUI_ICON "${NSISDIR}\Contrib\Graphics\Icons\modern-install.ico"
 23+!define MUI_ICON "..\common\dxgl48.ico"
2424 !define MUI_UNICON "${NSISDIR}\Contrib\Graphics\Icons\modern-uninstall.ico"
2525
2626 ; Welcome page
Index: common/dxgl.ico
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: common/dxgl48.ico
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: common/dxgl48.ico
___________________________________________________________________
Added: svn:mime-type
## -0,0 +1 ##
 27+application/octet-stream
\ No newline at end of property
Index: common/star.ico
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: dxglcfg/dxglcfg.cpp
@@ -897,6 +897,23 @@
898898
899899 break;
900900 case IDC_REMOVE:
 901+ if(!(GetWindowLong(hWnd,GWL_STYLE) & WS_DISABLED))
 902+ {
 903+ switch(MessageBox(hWnd,_T("Do you want to apply settings before continuing?\nIf you answer No, the unsaved settings will be discarded."),
 904+ _T("Unsaved settings detected"),MB_YESNOCANCEL))
 905+ {
 906+ case IDYES:
 907+ SaveChanges(hWnd);
 908+ break;
 909+ case IDNO:
 910+ break;
 911+ default:
 912+ return false;
 913+ }
 914+ }
 915+ // Delete app profile
 916+
 917+
901918 break;
902919 }
903920 break;