DXGL r544 - Code Review

Jump to navigation Jump to search
Repository:DXGL
Revision:r543‎ | r544 | r545 >
Date:01:07, 29 September 2014
Author:admin
Status:new
Tags:
Comment:
Un-overload EnumDisplayModes
Modified paths:
  • /ddraw/glDirectDraw.cpp (modified) (history)

Diff [purge]

Index: ddraw/glDirectDraw.cpp
@@ -343,7 +343,7 @@
344344 else return 0;
345345 }
346346
347 -HRESULT EnumDisplayModes(DWORD dwFlags, LPDDSURFACEDESC lpDDSurfaceDesc, LPVOID lpContext, LPDDENUMMODESCALLBACK lpEnumModesCallback)
 347+HRESULT EnumDisplayModes1(DWORD dwFlags, LPDDSURFACEDESC lpDDSurfaceDesc, LPVOID lpContext, LPDDENUMMODESCALLBACK lpEnumModesCallback)
348348 {
349349 if(!lpEnumModesCallback) return DDERR_INVALIDPARAMS;
350350 if (dwFlags & 0xFFFFFFFC) return DDERR_INVALIDPARAMS;
@@ -457,7 +457,7 @@
458458 free(modes);
459459 return DD_OK;
460460 }
461 -HRESULT EnumDisplayModes(DWORD dwFlags, LPDDSURFACEDESC2 lpDDSurfaceDesc, LPVOID lpContext, LPDDENUMMODESCALLBACK2 lpEnumModesCallback)
 461+HRESULT EnumDisplayModes2(DWORD dwFlags, LPDDSURFACEDESC2 lpDDSurfaceDesc, LPVOID lpContext, LPDDENUMMODESCALLBACK2 lpEnumModesCallback)
462462 {
463463 bool match;
464464 DWORD modenum = 0;
@@ -1009,7 +1009,7 @@
10101010 TRACE_ENTER(5,14,this,9,dwFlags,14,lpDDSurfaceDesc2,14,lpContext,14,lpEnumModesCallback);
10111011 if(!this) TRACE_RET(HRESULT,23,DDERR_INVALIDOBJECT);
10121012 if(!lpEnumModesCallback) TRACE_RET(HRESULT,23,DDERR_INVALIDPARAMS);
1013 - HRESULT ret = ::EnumDisplayModes(dwFlags,lpDDSurfaceDesc2,lpContext,lpEnumModesCallback);
 1013+ HRESULT ret = EnumDisplayModes2(dwFlags,lpDDSurfaceDesc2,lpContext,lpEnumModesCallback);
10141014 TRACE_EXIT(23,ret);
10151015 return ret;
10161016 }
@@ -2141,7 +2141,7 @@
21422142 {
21432143 TRACE_ENTER(5,14,this,9,dwFlags,14,lpDDSurfaceDesc,14,lpContext,14,lpEnumModesCallback);
21442144 if(!this) TRACE_RET(HRESULT,23,DDERR_INVALIDOBJECT);
2145 - TRACE_RET(HRESULT,23,::EnumDisplayModes(dwFlags,lpDDSurfaceDesc,lpContext,lpEnumModesCallback));
 2145+ TRACE_RET(HRESULT,23,EnumDisplayModes1(dwFlags,lpDDSurfaceDesc,lpContext,lpEnumModesCallback));
21462146 }
21472147 HRESULT WINAPI glDirectDraw1::EnumSurfaces(DWORD dwFlags, LPDDSURFACEDESC lpDDSD, LPVOID lpContext, LPDDENUMSURFACESCALLBACK lpEnumSurfacesCallback)
21482148 {
@@ -2342,7 +2342,7 @@
23432343 {
23442344 TRACE_ENTER(5,14,this,9,dwFlags,14,lpDDSurfaceDesc,14,lpContext,14,lpEnumModesCallback);
23452345 if(!this) TRACE_RET(HRESULT,23,DDERR_INVALIDOBJECT);
2346 - TRACE_RET(HRESULT,23,::EnumDisplayModes(dwFlags,lpDDSurfaceDesc,lpContext,lpEnumModesCallback));
 2346+ TRACE_RET(HRESULT,23,EnumDisplayModes1(dwFlags,lpDDSurfaceDesc,lpContext,lpEnumModesCallback));
23472347 }
23482348 HRESULT WINAPI glDirectDraw2::EnumSurfaces(DWORD dwFlags, LPDDSURFACEDESC lpDDSD, LPVOID lpContext, LPDDENUMSURFACESCALLBACK lpEnumSurfacesCallback)
23492349 {
@@ -2570,7 +2570,7 @@
25712571 {
25722572 TRACE_ENTER(5,14,this,9,dwFlags,14,lpDDSurfaceDesc,14,lpContext,14,lpEnumModesCallback);
25732573 if(!this) TRACE_RET(HRESULT,23,DDERR_INVALIDOBJECT);
2574 - TRACE_RET(HRESULT,23,::EnumDisplayModes(dwFlags,lpDDSurfaceDesc,lpContext,lpEnumModesCallback));
 2574+ TRACE_RET(HRESULT,23,EnumDisplayModes2(dwFlags,lpDDSurfaceDesc,lpContext,lpEnumModesCallback));
25752575 }
25762576 HRESULT WINAPI glDirectDraw4::EnumSurfaces(DWORD dwFlags, LPDDSURFACEDESC2 lpDDSD, LPVOID lpContext, LPDDENUMSURFACESCALLBACK2 lpEnumSurfacesCallback)
25772577 {