DXGL r762 - Code Review

Jump to navigation Jump to search
Repository:DXGL
Revision:r761‎ | r762 | r763 >
Date:07:20, 2 December 2017
Author:admin
Status:new
Tags:
Comment:
Adjust control positions in Effects tab.
Add controls for Blt scaling filter and color key alpha threshold.
Modified paths:
  • /dxglcfg/dxglcfg.rc (modified) (history)
  • /dxglcfg/resource.h (modified) (history)

Diff [purge]

Index: dxglcfg/dxglcfg.rc
@@ -152,20 +152,24 @@
153153 STYLE DS_3DLOOK | DS_CENTER | DS_SHELLFONT | WS_VISIBLE | WS_CHILDWINDOW
154154 FONT 8, "Ms Shell Dlg"
155155 {
156 - LTEXT "Postprocess scaler", IDC_STATIC, 7, 5, 61, 9, SS_LEFT, WS_EX_LEFT
157 - COMBOBOX IDC_POSTSCALE, 7, 15, 102, 30, CBS_DROPDOWNLIST | CBS_HASSTRINGS, WS_EX_LEFT
158 - LTEXT "Postprocess input miultiplier", IDC_STATIC, 114, 5, 90, 9, SS_LEFT, WS_EX_LEFT
159 - COMBOBOX IDC_POSTSCALESIZE, 114, 15, 102, 30, CBS_DROPDOWN | CBS_HASSTRINGS, WS_EX_LEFT
160 - AUTOCHECKBOX "Use post-processing shader", IDC_USESHADER, 7, 34, 103, 8, 0, WS_EX_LEFT
161 - COMBOBOX IDC_SHADER, 7, 44, 247, 92, WS_DISABLED | CBS_DROPDOWN | CBS_HASSTRINGS, WS_EX_LEFT
162 - PUSHBUTTON "...", IDC_BROWSESHADER, 256, 43, 20, 14, WS_DISABLED, WS_EX_LEFT
163 - LTEXT "Primary buffer scaling", IDC_STATIC, 7, 60, 70, 8, SS_LEFT, WS_EX_LEFT
164 - COMBOBOX IDC_PRIMARYSCALE, 7, 70, 101, 30, CBS_DROPDOWNLIST | CBS_HASSTRINGS, WS_EX_LEFT
165 - LTEXT "Custom scale", IDC_CUSTOMSCALELABEL, 7, 85, 44, 8, WS_DISABLED | SS_LEFT, WS_EX_LEFT
166 - LTEXT "X", IDC_CUSTOMSCALELABELX, 7, 98, 8, 8, WS_DISABLED | SS_LEFT, WS_EX_LEFT
167 - EDITTEXT IDC_CUSTOMSCALEX, 15, 95, 40, 14, WS_DISABLED | ES_AUTOHSCROLL, WS_EX_LEFT
168 - LTEXT "Y", IDC_CUSTOMSCALELABELY, 57, 98, 8, 8, WS_DISABLED | SS_LEFT, WS_EX_LEFT
169 - EDITTEXT IDC_CUSTOMSCALEY, 65, 95, 40, 14, WS_DISABLED | ES_AUTOHSCROLL, WS_EX_LEFT
 156+ LTEXT "Postprocess scaler", IDC_STATIC, 7, 7, 61, 9, SS_LEFT, WS_EX_LEFT
 157+ COMBOBOX IDC_POSTSCALE, 7, 17, 102, 30, CBS_DROPDOWNLIST | CBS_HASSTRINGS, WS_EX_LEFT
 158+ LTEXT "Postprocess input multiplier", IDC_STATIC, 114, 7, 90, 9, SS_LEFT, WS_EX_LEFT
 159+ COMBOBOX IDC_POSTSCALESIZE, 114, 17, 102, 30, CBS_DROPDOWN | CBS_HASSTRINGS, WS_EX_LEFT
 160+ AUTOCHECKBOX "Use post-processing shader", IDC_USESHADER, 7, 33, 103, 8, 0, WS_EX_LEFT
 161+ COMBOBOX IDC_SHADER, 7, 43, 247, 92, WS_DISABLED | CBS_DROPDOWN | CBS_HASSTRINGS, WS_EX_LEFT
 162+ PUSHBUTTON "...", IDC_BROWSESHADER, 256, 42, 20, 14, WS_DISABLED, WS_EX_LEFT
 163+ LTEXT "Primary buffer scaling", IDC_STATIC, 7, 58, 70, 8, SS_LEFT, WS_EX_LEFT
 164+ COMBOBOX IDC_PRIMARYSCALE, 7, 68, 102, 30, CBS_DROPDOWNLIST | CBS_HASSTRINGS, WS_EX_LEFT
 165+ LTEXT "Blt Scaling Filter", IDC_STATIC, 114, 58, 50, 8, SS_LEFT, WS_EX_LEFT
 166+ COMBOBOX IDC_BLTFILTER, 114, 68, 102, 92, CBS_DROPDOWNLIST | CBS_HASSTRINGS, WS_EX_LEFT
 167+ LTEXT "Blt Color Key Threshold", 0, 114, 83, 74, 9, SS_LEFT, WS_EX_LEFT
 168+ CONTROL "", IDC_BLTTHRESHOLD, TRACKBAR_CLASS, WS_TABSTOP | TBS_BOTH | TBS_NOTICKS, 114, 93, 102, 15, WS_EX_LEFT
 169+ LTEXT "Custom scale", IDC_CUSTOMSCALELABEL, 7, 83, 44, 8, WS_DISABLED | SS_LEFT, WS_EX_LEFT
 170+ LTEXT "X", IDC_CUSTOMSCALELABELX, 7, 96, 8, 8, WS_DISABLED | SS_LEFT, WS_EX_LEFT
 171+ EDITTEXT IDC_CUSTOMSCALEX, 15, 93, 40, 14, WS_DISABLED | ES_AUTOHSCROLL, WS_EX_LEFT
 172+ LTEXT "Y", IDC_CUSTOMSCALELABELY, 57, 96, 8, 8, WS_DISABLED | SS_LEFT, WS_EX_LEFT
 173+ EDITTEXT IDC_CUSTOMSCALEY, 65, 93, 40, 14, WS_DISABLED | ES_AUTOHSCROLL, WS_EX_LEFT
170174 }
171175
172176
Index: dxglcfg/resource.h
@@ -72,11 +72,13 @@
7373 #define IDC_SHADER 2104
7474 #define IDC_BROWSESHADER 2105
7575 #define IDC_PRIMARYSCALE 2106
76 -#define IDC_CUSTOMSCALELABEL 2107
77 -#define IDC_CUSTOMSCALELABELX 2108
78 -#define IDC_CUSTOMSCALEX 2109
79 -#define IDC_CUSTOMSCALELABELY 2110
80 -#define IDC_CUSTOMSCALEY 2111
 76+#define IDC_BLTFILTER 2107
 77+#define IDC_BLTTHRESHOLD 2108
 78+#define IDC_CUSTOMSCALELABEL 2109
 79+#define IDC_CUSTOMSCALELABELX 2110
 80+#define IDC_CUSTOMSCALEX 2111
 81+#define IDC_CUSTOMSCALELABELY 2112
 82+#define IDC_CUSTOMSCALEY 2113
8183
8284 // Controls - 3D Graphics Tab
8385 #define IDC_TEXFILTER 2201