DXGL r834 - Code Review

Jump to navigation Jump to search
Repository:DXGL
Revision:< r833‎ | r834 | r835 >
Date:00:05, 14 July 2018
Author:admin
Status:new
Tags:
Comment:
Add operating system detection for VS2017 builds in the installer.
Use Internet Archive URLs for Windows XP/2003 service pack installation information.
Modified paths:
  • /Installer/dxgl.nsi (modified) (history)

Diff [purge]

Index: Installer/dxgl.nsi
——@@ -248,6 +248,25 @@
249249
250250
251251 Function .onInit
 252+ !if ${COMPILER} == "VC2017_7"
 253+ ${IfNot} ${AtLeastWinVista}
 254+ MessageBox MB_OK|MB_ICONSTOP "This version of DXGL requires at least Windows Vista Service Pack 2.$\r\
 255+ If you need to run DXGL on Windows XP, XP x64, or Server 2003, please download the VS2010 build."
 256+ Quit
 257+ ${EndIf}
 258+ ${If} ${IsWinVista}
 259+ ${AndIfNot} ${AtLeastServicePack} 2
 260+ MessageBox MB_OK|MB_ICONSTOP "Your copy of Windows Vista or Windows Server 2008 must be upgraded to Service Pack 2 before you can use the VC2017 build of DXGL.$\r\
 261+ Please visit https://support.microsoft.com/en-us/kb/948465/ for instructions on upgrading to Service Pack 2."
 262+ Quit
 263+ ${endif}
 264+ ${If} ${IsWin7}
 265+ ${AndIfNot} ${AtLeastServicePack} 1
 266+ MessageBox MB_OK|MB_ICONSTOP "Your copy of Windows 7 or Windows Server 2008 R2 must be upgraded to Service Pack 1 before you can use the VC2017 build of DXGL.$\r\
 267+ Please visit X for instructions on upgrading to Service Pack 1."
 268+ Quit
 269+ ${endif}
 270+ !else
252271 ${IfNot} ${AtleastWinXP}
253272 MessageBox MB_OK|MB_ICONSTOP "This version of DXGL requires at least Windows XP Service Pack 3."
254273 Quit
——@@ -256,15 +275,16 @@
257276 ${AndIfNot} ${AtLeastServicePack} 3
258277 ${AndIfNot} ${RunningX64}
259278 MessageBox MB_OK|MB_ICONSTOP "Your copy of Windows XP must be upgraded to Service Pack 3 before you can use DXGL.$\r\
260 - Please visit https://support.microsoft.com/en-us/kb/322389/ for instructions on upgrading to Service Pack 3."
 279+ Please visit http://web.archive.org/web/20151010042325/https://support.microsoft.com/en-us/kb/322389/ for instructions on upgrading to Service Pack 3."
261280 Quit
262281 ${EndIf}
263282 ${If} ${IsWin2003}
264283 ${AndIfNot} ${AtLeastServicePack} 1
265284 MessageBox MB_OK|MB_ICONSTOP "Your copy of Windows Server 2003 must be upgraded to at least Service Pack 1 before you can use DXGL.$\r\
266 - Please visit https://support.microsoft.com/en-us/kb/889100/ for instructions on upgrading to Service Pack 2."
 285+ Please visit http://web.archive.org/web/20150501080245/https://support.microsoft.com/en-us/kb/889100/ for instructions on upgrading to Service Pack 2."
267286 Quit
268287 ${EndIf}
 288+ !endif
269289 !ifdef _DEBUG
270290 MessageBox MB_OK|MB_ICONEXCLAMATION "This is a debug build of DXGL. It is not meant for regular \
271291 usage and requires the debug version of the Visual C++ runtime to work.$\r$\r\
Retrieved from "https://dxgl.org/wiki/Special:Code/DXGL/834"