DXGL r169 - Code Review

Jump to navigation Jump to search
Repository:DXGL
Revision:r168‎ | r169 | r170 >
Date:15:35, 8 June 2012
Author:admin
Status:new
Tags:
Comment:
Fix up COM initialization.
Add troubleshooting document.
Add DLL paths registry file to installer.
Update version to 0.2.1
Modified paths:
  • /Help/Help.vcxproj (modified) (history)
  • /Help/Help.vcxproj.filters (modified) (history)
  • /Help/toc.hhc (modified) (history)
  • /Installer/dxgl.nsi (modified) (history)
  • /ReadMe.txt (modified) (history)
  • /common/version.h (modified) (history)
  • /common/version.nsh (modified) (history)
  • /ddraw/ddraw.cpp (modified) (history)
  • /ddraw/glClassFactory.cpp (modified) (history)

Diff [purge]

Index: Help/Help.vcxproj
@@ -71,6 +71,9 @@
7272 <DeploymentContent>true</DeploymentContent>
7373 </None>
7474 <None Include="toc.hhc" />
 75+ <None Include="troubleshooting.htm">
 76+ <DeploymentContent>true</DeploymentContent>
 77+ </None>
7578 </ItemGroup>
7679 <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
7780 <ImportGroup Label="ExtensionTargets">
Index: Help/Help.vcxproj.filters
@@ -27,5 +27,8 @@
2828 <None Include="dxgl.css">
2929 <Filter>Help files</Filter>
3030 </None>
 31+ <None Include="troubleshooting.htm">
 32+ <Filter>Help files</Filter>
 33+ </None>
3134 </ItemGroup>
3235 </Project>
\ No newline at end of file
Index: Help/toc.hhc
@@ -16,5 +16,9 @@
1717 <param name="Name" value="Configuration">
1818 <param name="Local" value="configuration.htm">
1919 </OBJECT>
 20+ <LI> <OBJECT type="text/sitemap">
 21+ <param name="Name" value="Troubleshooting">
 22+ <param name="Local" value="troubleshooting.htm">
 23+ </OBJECT>
2024 </UL>
2125 </BODY></HTML>
Index: Installer/dxgl.nsi
@@ -83,6 +83,7 @@
8484 File "..\ReadMe.txt"
8585 File "..\COPYING.txt"
8686 File "..\Help\dxgl.chm"
 87+ File "dllpaths.reg"
8788 CreateShortCut "$SMPROGRAMS\DXGL\DXGL Help.lnk" "$INSTDIR\dxgl.chm"
8889
8990 StrCpy $8 0
Index: ReadMe.txt
@@ -1,4 +1,4 @@
2 -DXGL 0.2.0
 2+DXGL 0.2.1
33 http://www.williamfeely.info/wiki/DXGL
44
55 == Introduction ==
Index: common/version.h
@@ -4,12 +4,12 @@
55
66 #define DXGLMAJOR 0
77 #define DXGLMINOR 2
8 -#define DXGLPOINT 0
 8+#define DXGLPOINT 1
99 #define DXGLBUILD 0
1010
1111 #define DXGLVERNUMBER DXGLMAJOR,DXGLMINOR,DXGLPOINT,DXGLBUILD
1212 #define DXGLVERQWORD (((unsigned __int64)DXGLMAJOR<<48)+((unsigned __int64)DXGLMINOR<<32)+((unsigned __int64)DXGLPOINT<<16)+(unsigned __int64)DXGLBUILD)
13 -#define DXGLVERSTRING "0.2.0.0"
 13+#define DXGLVERSTRING "0.2.1.0"
1414
1515
1616 #endif //__VERSION_H
Index: common/version.nsh
@@ -1 +1 @@
2 -!define PRODUCT_VERSION "0.2.0"
\ No newline at end of file
 2+!define PRODUCT_VERSION "0.2.1"
\ No newline at end of file
Index: ddraw/ddraw.cpp
@@ -472,7 +472,17 @@
473473 FIXME("SetAppCompatData: stub\n");
474474 }
475475
476 -/// Stub for function found in system ddraw.dll
 476+/**
 477+ * Test if the ddraw.dll file is DXGL. Do not link to this entry point.
 478+ * Use LoadLibrary and GetProcAddress instead.
 479+ * @return
 480+ * Returns TRUE
 481+ * @remark
 482+ * Test for DXGL by testing if this function exists. Please do not use
 483+ * this function to test whether your program should run or not. This
 484+ * function may be changed or removed in case of abuse.
 485+ */
 486+
477487 DDRAW_API BOOL IsDXGLDDraw()
478488 {
479489 return TRUE;
Index: ddraw/glClassFactory.cpp
@@ -63,6 +63,7 @@
6464 {
6565 glDD7 = new glDirectDraw7;
6666 *ppvObject = new glDirectDraw1(glDD7);
 67+ glDD7->Release();
6768 return S_OK;
6869 }
6970 if(riid == IID_IDirectDraw2)
@@ -69,6 +70,7 @@
7071 {
7172 glDD7 = new glDirectDraw7;
7273 *ppvObject = new glDirectDraw2(glDD7);
 74+ glDD7->Release();
7375 return S_OK;
7476 }
7577 if(riid == IID_IDirectDraw4)
@@ -75,6 +77,7 @@
7678 {
7779 glDD7 = new glDirectDraw7;
7880 *ppvObject = new glDirectDraw4(glDD7);
 81+ glDD7->Release();
7982 return S_OK;
8083 }
8184 if(riid == IID_IDirectDraw7)