DXGL r202 - Code Review

Jump to navigation Jump to search
Repository:DXGL
Revision:< r201‎ | r202 | r203 >
Date:16:26, 5 July 2012
Author:admin
Status:new
Tags:
Comment:
Remove dllpaths.reg and integrate COM fix in installer.
Modified paths:
  • /Help/troubleshooting.htm (modified) (history)
  • /Installer/dllpaths.reg (deleted) (history)
  • /Installer/dxgl.nsi (modified) (history)

Diff [purge]

Index: Installer/dllpaths.reg
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: Installer/dllpaths.reg
___________________________________________________________________
Deleted: svn:mime-type
## -1 +0,0 ##
1 -application/octet-stream
\ No newline at end of property
Index: Help/troubleshooting.htm
——@@ -10,8 +10,8 @@
1111 <h3>Cause: No application profile</h3>
1212 Solution: Open "Configure DXGL" and click the Add button. Browse to your program and double click it.
1313 <h3>Cause: System ddraw.dll registered under absolute path</h3>
14 - Solution: Open the file dllpaths.reg in the DXGL installation folder. This will fix initialization for the
15 - current user.
 14+ Solution: Make sure the "Fix DDraw COM Registration" option is selected when installing DXGL. After upgrading to Windows
 15+ 8, you may need to re-run the installer to set the registry keys.
1616 <h3>Cause: Program does not use DirectDraw</h3>
1717 Solution: Make sure your program is configured to use DirectDraw or Direct3D up to version 7.
1818 <h2>Problem: Program crashes</h2>
Index: Installer/dxgl.nsi
——@@ -3,6 +3,7 @@
44 SetCompressor /SOLID lzma
55
66 !include 'LogicLib.nsh'
 7+!include 'x64.nsh'
78
89 ; HM NIS Edit Wizard helper defines
910 !define PRODUCT_NAME "DXGL"
——@@ -86,7 +87,6 @@
8788 File "..\ReadMe.txt"
8889 File "..\COPYING.txt"
8990 File "..\Help\dxgl.chm"
90 - File "dllpaths.reg"
9191 CreateShortCut "$SMPROGRAMS\DXGL\DXGL Help.lnk" "$INSTDIR\dxgl.chm"
9292
9393 StrCpy $8 0
——@@ -168,6 +168,15 @@
169169
170170 Section "Fix DDraw COM registration" SEC_COMFIX
171171 DetailPrint "Setting DDraw Runtime path in registry"
 172+ ${If} ${RunningX64}
 173+ SetRegView 32
 174+ WriteRegStr HKCU "Software\Classes\CLSID\{D7B70EE0-4340-11CF-B063-0020AFC2CD35}\InprocServer32" "" "ddraw.dll"
 175+ WriteRegStr HKCU "Software\Classes\CLSID\{D7B70EE0-4340-11CF-B063-0020AFC2CD35}\InprocServer32" "ThreadingModel" "Both"
 176+ WriteRegStr HKCU "Software\Classes\CLSID\{3C305196-50DB-11D3-9CFE-00C04FD930C5}\InprocServer32" "" "ddraw.dll"
 177+ WriteRegStr HKCU "Software\Classes\CLSID\{3C305196-50DB-11D3-9CFE-00C04FD930C5}\InprocServer32" "ThreadingModel" "Both"
 178+ WriteRegStr HKCU "Software\Classes\CLSID\{593817A0-7DB3-11CF-A2DE-00AA00B93356}\InprocServer32" "" "ddraw.dll"
 179+ WriteRegStr HKCU "Software\Classes\CLSID\{593817A0-7DB3-11CF-A2DE-00AA00B93356}\InprocServer32" "ThreadingModel" "Both"
 180+ ${EndIf}
172181 SectionEnd
173182
174183 Section -AdditionalIcons
——@@ -211,8 +220,6 @@
212221 BelowEight:
213222 SectionSetFlags ${SEC_COMFIX} 0
214223 VersionFinish:
215 -
216 -
217224 FunctionEnd
218225
219226
Retrieved from "https://dxgl.org/wiki/Special:Code/DXGL/202"