DXGL r341 - Code Review

Jump to navigation Jump to search
Repository:DXGL
Revision:r340‎ | r341 | r342 >
Date:00:54, 28 February 2013
Author:admin
Status:new
Tags:
Comment:
Remove non-working texture filtering optimization.
Update help file.
Update release version.
Modified paths:
  • /Help/configuration.htm (modified) (history)
  • /ReadMe.txt (modified) (history)
  • /common/releasever.h (modified) (history)
  • /ddraw/glDirectDrawSurface.cpp (modified) (history)

Diff [purge]

Index: Help/configuration.htm
@@ -62,7 +62,7 @@
6363 If checked, adds additional, mostly low resolution, display modes to the list generated by IDirectDraw::EnumDisplayModes. Only works if
6464 "Video mode" is not set to "Change desktop resolution."
6565 <h2><a name="alldepths" />Support All Color Depths</h2>
66 - If checked, adds 8, 15, 16, 24, and 32-bit color modes if not listed by the system. Windows 8 users should check this box.
 66+ If checked, adds 8, 15, 16, 24, and 32-bit color modes if not listed by the system. Under Windows 8 or above, this will be enabled by default.
6767 <h2><a name="scaler" />Scaling method</h2>
6868 Selects the filter to use for scaling the output when the resolution is different than the desktop resolution,
6969 as well as for blitting operations. The following methods are available:
@@ -69,7 +69,7 @@
7070 <h3>Nearest</h3>
7171 Uses nearest-neighbor scaling.
7272 <h3>Bilinear</h3>
73 - Uses bilinear scaling. Reduces jagged edges, but may create visual artifacts in some applications. Does not work with 8-bit color.
 73+ Uses bilinear scaling. Reduces jagged edges, but may create visual artifacts in some applications. Does not work with 8-bit color except for the full-screen scaling modes.
7474 <h3>Custom shader</h3>
7575 (not implemented) Uses a custom GLSL pixel shader to display the image.
7676 <h3>Shader (primary only)</h3>
Index: ReadMe.txt
@@ -1,4 +1,4 @@
2 -DXGL 0.4.2
 2+DXGL 0.5.0
33 http://www.williamfeely.info/wiki/DXGL
44
55 == Introduction ==
Index: common/releasever.h
@@ -3,8 +3,8 @@
44 #define __VERSION_H
55
66 #define DXGLMAJORVER 0
7 -#define DXGLMINORVER 4
8 -#define DXGLPOINTVER 2
 7+#define DXGLMINORVER 5
 8+#define DXGLPOINTVER 0
99
1010 #define STR2(x) #x
1111 #define STR(x) STR2(x)
Index: ddraw/glDirectDrawSurface.cpp
@@ -1227,17 +1227,18 @@
12281228 min = GL_LINEAR_MIPMAP_LINEAR;
12291229 break;
12301230 }
1231 - if((magfilter != mag) || (minfilter != min)) ::SetTexture(level,texture);
1232 - if(magfilter != mag)
1233 - {
 1231+ //if((magfilter != mag) || (minfilter != min))
 1232+ ::SetTexture(level,texture);
 1233+ //if(magfilter != mag)
 1234+ //{
12341235 glTexParameteri(GL_TEXTURE_2D,GL_TEXTURE_MAG_FILTER,mag);
12351236 magfilter = mag;
1236 - }
1237 - if(minfilter != min)
1238 - {
 1237+ //}
 1238+ //if(minfilter != min)
 1239+ //{
12391240 glTexParameteri(GL_TEXTURE_2D,GL_TEXTURE_MIN_FILTER,min);
12401241 minfilter = min;
1241 - }
 1242+ //}
12421243 }
12431244
12441245 HRESULT glDirectDrawSurface7::GetHandle(glDirect3DDevice7 *glD3DDev7, LPD3DTEXTUREHANDLE lpHandle)