DXGL r473 - Code Review

Jump to navigation Jump to search
Repository:DXGL
Revision:r472‎ | r473 | r474 >
Date:00:56, 30 July 2014
Author:admin
Status:new
Tags:
Comment:
Remove shader options in scaler setting.
Update help file to open with proper size.
Modified paths:
  • /Help/configuration.htm (modified) (history)
  • /Help/dxgl.hhp (modified) (history)
  • /cfgmgr/ReadMe.txt (modified) (history)
  • /dxglcfg/dxglcfg.c (modified) (history)
  • /dxglcfg/dxglcfg.rc (modified) (history)

Diff [purge]

Index: Help/configuration.htm
@@ -72,10 +72,6 @@
7373 Uses nearest-neighbor scaling.
7474 <h3>Bilinear</h3>
7575 Uses bilinear scaling. Reduces jagged edges, but may create visual artifacts in some applications. Does not work with 8-bit color except for the full-screen scaling modes.
76 - <h3>Custom shader</h3>
77 - (not implemented) Uses a custom GLSL pixel shader to display the image.
78 - <h3>Shader (primary only)</h3>
79 - (not implemented) Uses a custom GLSL pixel shader to display the primary buffer.
8076 <h2><a name="aspect" />Screen aspect ratio</h2>
8177 Overrides the aspect ratio for "Aspect corrected stretch" and "Scale if mode not found". Enter as x:y or as a floating point ratio, for example 4:3 or 1.333333, or select a preset from the dropdown list. Default uses a square pixel ratio.
8278 <h2><a name="dpiscale" />DPI scaling mode</h2>
Index: Help/dxgl.hhp
@@ -2,12 +2,16 @@
33 Compatibility=1.1 or later
44 Compiled file=dxgl.chm
55 Contents file=toc.hhc
 6+Default Window=DXGL Help
67 Default topic=introduction.htm
78 Display compile progress=No
89 Language=0x409 English (United States)
910 Title=DXGL Help
1011
 12+[WINDOWS]
 13+DXGL Help=,"toc.hhc",,"introduction.htm",,,,,,0x22520,,0x3006,[0,0,922,684],0x318f0000,,,,,,0
1114
 15+
1216 [FILES]
1317 introduction.htm
1418 configuration.htm
Index: cfgmgr/ReadMe.txt
@@ -22,8 +22,6 @@
2323 Valid settings:
2424 0 - Nearest-neighbor stretching
2525 1 - Bilinear interpolation
26 -2 - Use pixel shader defined by shaderfile
27 -3 - Use pixel shader defined by shaderfile, only on primary surface.
2826
2927 Member highres
3028 REG_DWORD HKCU\DXGL\<app>\AdjustPrimaryResolution
@@ -76,7 +74,7 @@
7775
7876 Member shaderfile
7977 REG_SZ HKCU\DXGL\<app>\ShaderFile
80 -Full path to file containing a custom pixel shader for 2D blits.
 78+Full path to file containing a post-process shader script.
8179
8280 Member SortModes
8381 REG_DWORD HKCU\DXGL\<app>\SortModes
Index: dxglcfg/dxglcfg.c
@@ -540,10 +540,6 @@
541541 SendDlgItemMessage(hWnd,IDC_SCALE,CB_ADDSTRING,0,(LPARAM)buffer);
542542 _tcscpy(buffer,_T("Bilinear"));
543543 SendDlgItemMessage(hWnd,IDC_SCALE,CB_ADDSTRING,1,(LPARAM)buffer);
544 - _tcscpy(buffer,_T("Custom shader"));
545 - SendDlgItemMessage(hWnd,IDC_SCALE,CB_ADDSTRING,2,(LPARAM)buffer);
546 - _tcscpy(buffer,_T("Shader (primary only)"));
547 - SendDlgItemMessage(hWnd,IDC_SCALE,CB_ADDSTRING,3,(LPARAM)buffer);
548544 SendDlgItemMessage(hWnd,IDC_SCALE,CB_SETCURSEL,cfg->scalingfilter,0);
549545 // aspect
550546 _tcscpy(buffer,_T("Default"));
Index: dxglcfg/dxglcfg.rc
@@ -49,7 +49,7 @@
5050 COMBOBOX IDC_SCALE, 195, 79, 102, 30, CBS_DROPDOWNLIST | CBS_HASSTRINGS
5151 LTEXT "Vertical sync", IDC_STATIC, 299, 69, 41, 8, SS_LEFT
5252 COMBOBOX IDC_VSYNC, 299, 79, 100, 30, CBS_DROPDOWNLIST | CBS_HASSTRINGS
53 - LTEXT "Scaling shader", IDC_STATIC, 195, 94, 47, 8, SS_LEFT
 53+ LTEXT "Post-processing shader", IDC_STATIC, 195, 94, 90, 8, SS_LEFT
5454 EDITTEXT IDC_SHADER, 195, 104, 183, 14, ES_AUTOHSCROLL
5555 PUSHBUTTON "...", IDC_BROWSESHADER, 379, 104, 20, 14
5656 LTEXT "Screen aspect ratio", IDC_STATIC, 195, 120, 63, 8, SS_LEFT