DXGL r76 - Code Review

Jump to navigation Jump to search
Repository:DXGL
Revision:< r75‎ | r76 | r77 >
Date:20:23, 14 January 2012
Author:admin
Status:new
Tags:
Comment:
Release 0.1.3
Remove 3D support from Release builds
Modified paths:
  • /common/version.h (modified) (history)
  • /common/version.nsh (modified) (history)
  • /ddraw/glDirectDraw.cpp (modified) (history)
  • /dxgltest/dxgltest.cpp (modified) (history)

Diff [purge]

Index: common/version.h
——@@ -4,11 +4,11 @@
55
66 #define DXGLMAJOR 0
77 #define DXGLMINOR 1
8 -#define DXGLPOINT 2
 8+#define DXGLPOINT 3
99 #define DXGLBUILD 0
1010
1111 #define DXGLVERNUMBER DXGLMAJOR,DXGLMINOR,DXGLPOINT,DXGLBUILD
12 -#define DXGLVERSTRING "0.1.2.0"
 12+#define DXGLVERSTRING "0.1.3.0"
1313
1414
1515 #endif //__VERSION_H
Index: common/version.nsh
——@@ -1 +1 @@
2 -!define PRODUCT_VERSION "0.1.2"
\ No newline at end of file
 2+!define PRODUCT_VERSION "0.1.3"
\ No newline at end of file
Index: ddraw/glDirectDraw.cpp
——@@ -630,9 +630,14 @@
631631 }
632632 if(riid == IID_IDirect3D7)
633633 {
 634+ #ifdef _DEBUG
634635 this->AddRef();
635636 *ppvObj = new glDirect3D7(this);
636637 return DD_OK;
 638+ #else
 639+ FIXME("Add IDirect3D Interfaces\n");
 640+ ERR(DDERR_GENERIC);
 641+ #endif
637642 }
638643 if(riid == IID_IDirectDrawGammaControl)
639644 {
Index: dxgltest/dxgltest.cpp
——@@ -713,15 +713,21 @@
714714 tab.pszText = _T("2D Graphics");
715715 hTab = GetDlgItem(hWnd,IDC_TABS);
716716 SendDlgItemMessage(hWnd,IDC_TABS,TCM_INSERTITEM,1,(LPARAM)&tab);
 717+ #ifdef _DEBUG
717718 tab.pszText = _T("3D Graphics");
718719 SendDlgItemMessage(hWnd,IDC_TABS,TCM_INSERTITEM,2,(LPARAM)&tab);
 720+ #endif
719721 tabwnd[0] = CreateDialog(hinstance,MAKEINTRESOURCE(IDD_SYSINFO),hTab,SysTabCallback);
720722 tabwnd[1] = CreateDialog(hinstance,MAKEINTRESOURCE(IDD_TESTGFX),hTab,Test2DCallback);
 723+ #ifdef _DEBUG
721724 tabwnd[2] = CreateDialog(hinstance,MAKEINTRESOURCE(IDD_TESTGFX),hTab,Test3DCallback);
 725+ #endif
722726 SendDlgItemMessage(hWnd,IDC_TABS,TCM_GETITEMRECT,0,(LPARAM)&tabrect);
723727 SetWindowPos(tabwnd[0],NULL,tabrect.left,tabrect.bottom+3,0,0,SWP_SHOWWINDOW|SWP_NOSIZE);
724728 ShowWindow(tabwnd[1],SW_HIDE);
 729+ #ifdef _DEBUG
725730 ShowWindow(tabwnd[2],SW_HIDE);
 731+ #endif
726732 tabopen = 0;
727733 ShowWindow(hWnd,SW_SHOWNORMAL);
728734 return TRUE;
Retrieved from "https://dxgl.org/wiki/Special:Code/DXGL/76"