DXGL r878 - Code Review

Jump to navigation Jump to search
Repository:DXGL
Revision:r877‎ | r878 | r879 >
Date:02:21, 13 November 2018
Author:admin
Status:new
Tags:
Comment:
Make installer readable in high contrast mode.
Add manifest file to build tool (so error dialogs will have proper theming).
Modified paths:
  • /Installer/dxgl.nsi (modified) (history)
  • /buildtool/buildtool.rc (modified) (history)
  • /buildtool/xp.manifest (added) (history)

Diff [purge]

Index: Installer/dxgl.nsi
@@ -51,6 +51,7 @@
5252 !endif
5353
5454 ; MUI2
 55+!define MUI_BGCOLOR "SYSCLR:Window"
5556 !include "MUI2.nsh"
5657
5758 ; MUI Settings
Index: buildtool/buildtool.rc
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: buildtool/xp.manifest
@@ -0,0 +1,31 @@
 2+<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
 3+<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0" xmlns:asmv3="urn:schemas-microsoft-com:asm.v3" >
 4+ <assemblyIdentity
 5+ version="1.0.0.0"
 6+ processorArchitecture="X86"
 7+ name="WilliamFeely.DXGL.BuildTool"
 8+ type="win32"
 9+/>
 10+<description>DXGL Build Tool</description>
 11+<dependency>
 12+ <dependentAssembly>
 13+ <assemblyIdentity
 14+ type="win32"
 15+ name="Microsoft.Windows.Common-Controls"
 16+ version="6.0.0.0"
 17+ processorArchitecture="X86"
 18+ publicKeyToken="6595b64144ccf1df"
 19+ language="*"
 20+ />
 21+ </dependentAssembly>
 22+</dependency>
 23+ <compatibility xmlns="urn:schemas-microsoft-com:compatibility.v1">
 24+ <application>
 25+ <supportedOS Id="{e2011457-1546-43c5-a5fe-008deee3d3f0}"/>
 26+ <supportedOS Id="{4a2f28e3-53b9-4441-ba9c-d69d4a4a6e38}"/>
 27+ <supportedOS Id="{35138b9a-5d96-4fbd-8e2d-a2440225f93a}"/>
 28+ <supportedOS Id="{1f676c76-80e1-4239-95bb-83d0f6d0da78}"/>
 29+ <supportedOS Id="{8e0f7a12-bfb3-4fe8-b9a5-48fd50a15a9a}"/>
 30+ </application>
 31+ </compatibility>
 32+</assembly>
\ No newline at end of file