DXGL r929 - Code Review

Jump to navigation Jump to search
Repository:DXGL
Revision:r928‎ | r929 | r930 >
Date:14:00, 19 May 2019
Author:admin
Status:new
Tags:
Comment:
Set version to 0.5.17 beta.
Fix building installer in beta mode.
Update readme and fix Markdown.
Modified paths:
  • /ReadMe.md (modified) (history)
  • /buildtool/buildtool.c (modified) (history)
  • /common/releasever.h (modified) (history)

Diff [purge]

Index: ReadMe.md
@@ -1,98 +1,102 @@
2 -# DXGL 0.5.16
3 -https://dxgl.org
4 -
5 -## Introduction
6 -DXGL is a free replacement for the Windows ddraw.dll library, running on OpenGL. It is designed to overcome driver bugs, particularly in Windows Vista and newer operating systems. It also adds various enhancements to the graphics output such as display scaling and filtering options. DXGL supports the DirectX 7.0 graphics APIs, however it is currently under development and many programs are not yet compatible with DXGL.
7 -
8 -## Updgrade notes
9 -If you upgrade from DXGL 0.5.8 or earlier, the configuration format will be changed, and earlier versions of DXGL will no longer recognize the profiles.
10 -In addition, any profiles generated by older versions of DXGL going forward will not be recognized by DXGL 0.5.9 or later.
11 -If you wish to migrate any old profiles generated after installing DXGL 0.5.9 or later, you will need to use Regedit to delete the "Configuration Version" registry value from the HKEY_CURRENT_USER\SOFTWARE\DXGL registry key to force the upgrade to be run again.
12 -
13 -## GitHub Notice
14 -If you downloaded the DXGL source code from GitHub, please note that when compiling DXGL, the version number will not indicate the revision number. This issue is also present when compiling from a zipped source code distribution from the dxgl.org, www.dxgl.info, or www.williamfeely.info website.
15 -
16 -## System Requirements
17 -
18 -* Windows Vista (with SP2), 7 (with SP1), 8, 8.1, or 10 (standard build)
19 -* Windows XP (with SP3), Vista, 7, 8, 8.1, or 10 (legacy build)
20 - * Also compatible with most versions of Wine, by setting the ddraw DLL override to "native, builtin" which is done automatically at installation.
21 - * Not compatible with Windows 10 in S mode.
22 -* OpenGL 2.0 or higher compatible video card
23 - * Requires support for Framebuffer objects
24 - * Requires support for hardware accelerated non-power-of-two textures
25 - * OpenGL 3.2 or higher recommended.
26 -* The standard build requires a SSE2-capable processor; older processors require the legacy build.
27 -* For the standard build, Visual C++ 2019 x86 runtime, available at https://aka.ms/vs/16/release/vc_redist.x86.exe (note this link may track visitors) (will be installed if not present)
28 -* For the legacy build, Visual C++ 2010 x86 runtime, available at https://www.microsoft.com/en-us/download/details.aspx?id=8328 (will be installed if not present)
29 -
30 -## Build Requirements
31 -* For the legacy build, Visual Studio 2010 or Visual C++ 2010 Express Edition with Service Pack 1.
32 -* For the standard build, Visual Studio 2019, Community or higher.
33 -* The following components are optional. The build process will ask for these if they do not exist:
34 - * TortoiseSVN (to fill in revision on SVN builds)
35 - * HTML Help Workshop (to build help)
36 - * NSIS (to build installer, requires TortoiseSVN and HTML Help Workshop to succeed)
37 -
38 -## Build Instructions
39 -These instructions assume that you do not have any of the required software installed. If you already have any or all of this software installed and set up, skip those steps.
40 -* Install Visual Studio 2019 Community at https://visualstudio.microsoft.com/
41 -* Install TortoiseSVN from https://tortoisesvn.net/
42 -* Install HTML Help Workshop from https://www.microsoft.com/en-us/download/details.aspx?id=21138
43 -* Install NSIS from https://nsis.sourceforge.io/Main_Page
44 -* Open the dxgl.sln file, select your build configuration (Debug or Release) in the toolbar, and press F7 to build.
45 -
46 -## Progress
47 -For detailed progress information, please check https://www.williamfeely.info/wiki/DXGL_Features
48 -What works:
49 -* DirectDraw object creation and destruction (versions 1 to 7)
50 -* Display mode enumeration and switching (with emulated mode switching)
51 -* Fullscreen and windowed modes.
52 -* Basic Blt() functionality
53 -* 8-bit color emulated with GLSL shader
54 -* Packed-pixel YUV surfaces (currently only supported by Blt() to an RGB surface)
55 -
56 -What partially works:
57 -* 3D graphics are only partially supported.
58 -* Overlay support is currently in development and not yet enabled.
59 -
60 -What doesn't work:
61 -* Many functions are stubbed out and return an error
62 -
63 -## Installation
64 -
65 -Run the installer. When the installer completes, open DXGL Config and add your program files to the config program.
66 -To uninstall, go to the Add/Remove Programs or Programs and Features control panel and uninstall.
67 -
68 -## SVN
69 -
70 -SVN readonly access is available at:
71 -https://dxgl.org/svn/dxgl/
72 -Alternate URL at:
73 -https://dxgl.org:8443/svn/dxgl/
74 -
75 -There is a Mediawiki-based SVN log at:
76 -https://dxgl.org/wiki/Special:Code/DXGL
77 -
78 -## AppDB
79 -
80 -An AppDB system (similar to that on winehq.org) is now available at:
81 -https://dxgl.org/appdb/
82 -
83 -This requires a user account separate from the other services.
84 -
85 -Please note that the AppDB is now deprecated and will be made read-only once the new DXGL Wiki launches.
86 -
87 -## Discussion boards
88 -
89 -You may discuss DXGL at:
90 -https://forum.dxgl.info
91 -
92 -You must create a forum account to post content. For bug reports, please refer to the next section.
93 -
94 -## Bug reports
95 -
96 -Bug reports are managed by a Bugzilla system available at:
97 -https://www.dxgl.info/bugzilla/
98 -
99 -A user account needs to be created at this site to post bug reports.
 2+# DXGL 0.5.17 +https://dxgl.org + +## Introduction +DXGL is a free replacement for the Windows ddraw.dll library, running on OpenGL. It is designed to overcome driver bugs, particularly in Windows Vista and newer operating systems. It also adds various enhancements to the graphics output such as display scaling and filtering options. DXGL supports the DirectX 7.0 graphics APIs, however it is currently under development and many programs are not yet compatible with DXGL. + +## Updgrade notes +If you upgrade from DXGL 0.5.8 or earlier, the configuration format will be changed, and earlier versions of DXGL will no longer recognize the profiles. +In addition, any profiles generated by older versions of DXGL going forward will not be recognized by DXGL 0.5.9 or later. +If you wish to migrate any old profiles generated after installing DXGL 0.5.9 or later, you will need to use Regedit to delete the "Configuration Version" registry value from the HKEY_CURRENT_USER\SOFTWARE\DXGL registry key to force the upgrade to be run again. + +## GitHub Notice +If you downloaded the DXGL source code from GitHub, please note that when compiling DXGL, the version number will not indicate the revision number. This issue is also present when compiling from a zipped source code distribution from the dxgl.org, www.dxgl.info, or www.williamfeely.info website. + +## System Requirements + +* Windows Vista (with SP2), 7 (with SP1), 8, 8.1, or 10 (standard build) +* Windows XP (with SP3), Vista, 7, 8, 8.1, or 10 (legacy build) + * Also compatible with most versions of Wine, by setting the ddraw DLL override to "native, builtin" which is done automatically at installation. + * Not compatible with Windows 10 in S mode. +* OpenGL 2.0 or higher compatible video card + * Requires support for Framebuffer objects + * Requires support for hardware accelerated non-power-of-two textures + * OpenGL 3.2 or higher recommended. +* The standard build requires a SSE2-capable processor; older processors require the legacy build. +* For the standard build, Visual C++ 2019 x86 runtime, available at https://aka.ms/vs/16/release/vc_redist.x86.exe (note this link may track visitors) (will be installed if not present) +* For the legacy build, Visual C++ 2010 x86 runtime, available at https://www.microsoft.com/en-us/download/details.aspx?id=8328 (will be installed if not present) + +## Build Requirements +* For the legacy build, Visual Studio 2010 or Visual C++ 2010 Express Edition with Service Pack 1. +* For the standard build, Visual Studio 2019, Community or higher. +* The following components are optional. The build process will ask for these if they do not exist: + * TortoiseSVN (to fill in revision on SVN builds) + * HTML Help Workshop (to build help) + * NSIS (to build installer, requires TortoiseSVN and HTML Help Workshop to succeed) + +## Build Instructions +These instructions assume that you do not have any of the required software installed. If you already have any or all of this software installed and set up, skip those steps. + +* Install Visual Studio 2019 Community at https://visualstudio.microsoft.com/ +* Install TortoiseSVN from https://tortoisesvn.net/ +* Install HTML Help Workshop from https://www.microsoft.com/en-us/download/details.aspx?id=21138 +* Install NSIS from https://nsis.sourceforge.io/Main_Page +* Open the dxgl.sln file, select your build configuration (Debug or Release) in the toolbar, and press F7 to build. + +## Progress +For detailed progress information, please check https://www.williamfeely.info/wiki/DXGL_Features +What works: + +* DirectDraw object creation and destruction (versions 1 to 7) +* Display mode enumeration and switching (with emulated mode switching) +* Fullscreen and windowed modes. +* Basic Blt() functionality +* 8-bit color emulated with GLSL shader +* Packed-pixel YUV surfaces (currently only supported by Blt() to an RGB surface) + +What partially works: + +* 3D graphics are only partially supported. +* Overlay support is currently in development and not yet enabled. + +What doesn't work: + +* Many functions are stubbed out and return an error + +## Installation + +Run the installer. When the installer completes, open DXGL Config and add your program files to the config program. +To uninstall, go to the Add/Remove Programs or Programs and Features control panel and uninstall. + +## SVN + +SVN readonly access is available at: +https://dxgl.org/svn/dxgl/ +Alternate URL at: +https://dxgl.org:8443/svn/dxgl/ + +There is a Mediawiki-based SVN log at: +https://dxgl.org/wiki/Special:Code/DXGL + +## AppDB + +An AppDB system (similar to that on winehq.org) is now available at: +https://dxgl.org/appdb/ + +This requires a user account separate from the other services. + +Please note that the AppDB is now deprecated and will be made read-only once the new DXGL Wiki launches. + +## Discussion boards + +You may discuss DXGL at: +https://forum.dxgl.info + +You must create a forum account to post content. For bug reports, please refer to the next section. + +## Bug reports + +Bug reports are managed by a Bugzilla system available at: +https://www.dxgl.info/bugzilla/ + +A user account needs to be created at this site to post bug reports. Index: buildtool/buildtool.c
@@ -237,8 +237,8 @@
238238 findptr = strstr(buffer, "$SIGNTOOL");
239239 if (findptr)
240240 {
241 - if (nosign) strncpy(findptr, "\"0\"", 10);
242 - else strncpy(findptr, "\"1\"", 10);
 241+ if (nosign) strncpy(findptr, "\"0\"\n", 10);
 242+ else strncpy(findptr, "\"1\"\n", 10);
243243 }
244244 if (DXGLBETA)
245245 {
Index: common/releasever.h
@@ -4,8 +4,8 @@
55
66 #define DXGLMAJORVER 0
77 #define DXGLMINORVER 5
8 -#define DXGLPOINTVER 16
9 -#define DXGLBETA 0
 8+#define DXGLPOINTVER 17
 9+#define DXGLBETA 1
1010
1111 #define STR2(x) #x
1212 #define STR(x) STR2(x)
@@ -17,6 +17,6 @@
1818 1 - sign non-beta only
1919 2 - sign release only
2020 3 - sign all */
21 -#define SIGNMODE 0
 21+#define SIGNMODE 1
2222
2323 #endif //__VERSION_H